docs: added missing step from multi tentant example quick start #10362
+33
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelparkadze
changed the title
AlessioGr
requested changes
Jan 6, 2025
| Duplicate the .env.example file and rename it to .env. | ||
|
|
||
|
|
||
| ```bash |
There was a problem hiding this comment.
I don't think it's necessary to document the contents of .env.example, as the user will already have them once they copy .env.example to .env
There was a problem hiding this comment.
@AlessioGr I agree, I looked at the other README files of the other examples, they include the cp command example for this part. Let me know if this way is better.
replaced the contents of the .env file with the cp command example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the README.md of the multi tenant example, I tried to run the project and got an error of a missing secret key. I didn't understand instantly that its because I didn't setup the .env file so I thought it would be a good addition to the documentation.
Additionaly minor "beautification" of the quick start section.
Before (screenshot):
After (screenshot):
